Upload test coverage to Codecov #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanChristopheMorinPerso
force-pushed
the
coverage
branch
from
ae8f7aa to
560174a
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Signed-off-by: Jean-Christophe Morin <[email protected]>
JeanChristopheMorinPerso
force-pushed
the
coverage
branch
from
3385006 to
a3a221a
Compare
Pixel-Minions
added a commit
to Pixel-Minions/rez
that referenced
this pull request
Sep 26, 2024
Signed-off-by: Jean-Christophe Morin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1653
I initially wanted to use SonarCloud because it's already set tup, but we can't upload coverage for PRs coming from forks. That's because SonarCloud really wants an API token and GH Actions secrets are not available on PRs coming from forks.
So I instead use codecov. It's a service I use and is highly customizable and uploading coverage on fork PRs works without tokens.
This PR also enhances the development experience a bit.
rez-selftestused tocdinto the tests folder, which means that coverage result would be stored in the tests folder. This makes it very hard to find it, particularly when using the install script. pytest would just say "stored in htmlcov dir"... The new behavior is to not change the current working directory.